Basic information

• requester name: Zena

• requester Github id: Zena-park

• Project codename: ECO

• Review branch link: https://github.com/tokamak-network/ton-staking-v2/tree/codeReview

  • commit hash: 47253dc06d3f48a19820f88e3cb72c0a829bea2b (update docs) dd125e0e18ea3c10d20e13ff871ed739db3ca2c9

• Expected review duration (# of business days): 14 days

• Review completion deadline (YYYY-MM-DD): 2024-07-17

• Development specifications : https://github.com/tokamak-network/ton-staking-v2/blob/codeReview/docs/en/ton-staking-v2.md

• Contract scope (Contract subject to code review)

  • https://github.com/tokamak-network/ton-staking-v2/blob/codeReview/contracts/layer2/L2RegistryProxy.sol
  • https://github.com/tokamak-network/ton-staking-v2/blob/codeReview/contracts/layer2/L2RegistryV1_1.sol
  • https://github.com/tokamak-network/ton-staking-v2/blob/codeReview/contracts/layer2/Layer2ManagerProxy.sol
  • https://github.com/tokamak-network/ton-staking-v2/blob/codeReview/contracts/layer2/Layer2ManagerV1_1.sol
  • ‣
  • https://github.com/tokamak-network/ton-staking-v2/blob/codeReview/contracts/layer2/factory/OperatorFactory.sol
  • https://github.com/tokamak-network/ton-staking-v2/blob/codeReview/contracts/layer2/OperatorV1_1.sol
  • https://github.com/tokamak-network/ton-staking-v2/blob/codeReview/contracts/dao/Layer2CandidateProxy.sol
  • https://github.com/tokamak-network/ton-staking-v2/blob/codeReview/contracts/dao/Layer2CandidateV1_1.sol
  • https://github.com/tokamak-network/ton-staking-v2/blob/codeReview/contracts/dao/DAOCommitteeAddV1_1.sol#L109
    • Only the createLayer2Candidate function is subject to code review.
  • https://github.com/tokamak-network/ton-staking-v2/blob/codeReview/contracts/stake/managers/SeigManagerV1_3.sol
  • https://github.com/tokamak-network/ton-staking-v2/blob/codeReview/contracts/stake/managers/DepositManagerV1_1.sol

• Number of functions in each contract

  <aside> 💡 This is taken into consideration when allocating points.

  </aside>

  Number of functions

Requirement checklists

Readme.md

• [x] Does your repository have readme.md?

  https://github.com/tokamak-network/ton-staking-v2/tree/codeReview?tab=readme-ov-file#ton-staking-v2-upgrade-development

• Contract information

  • [x] Overview: What is the contract about? (share any relevant links)
  • [x] List of requirements: what are requirements for the contract? (share any relevant links)
  • [x] Environment setting example
  • [x] Test example

General

• [x] Does your code contain sufficient commenting?
• [x] Does your code contain sufficient test scripts?

Agreement

• [x] I understand that it is my responsibility as a review requester to either make a new commit based on the review or explain the issue with the review (ex: duplicated issue, not an issue, etc)

Caution