Basic information

• Project codename: gem-nft-contract

• Code review reward amount in TON: 2000

• requester name: Mehdi

• requester Github id: mehdi-defiesta

• Review branch link: https://github.com/tokamak-network/gem-nft-contract/tree/codeReview2

  • commit hash: 5b7a8c13b58835f9dd8aa2f66465f6a39f471d3e

• Expected review duration (# of business days): 14 days

• Review completion deadline (YYYY-MM-DD): 2024.11.05

• Explanation of the repository (Readme.md link): https://github.com/tokamak-network/gem-nft-contract/blob/codeReview/README.md

• Contract scope

  Smart Contract Name	nSLOC
  common/AuthControl.sol	61
  common/AuthRole.sol	5
  L1/L1WrappedStakedTON.sol	169
  L1/L1WrappedStakedTONFactory.sol.sol	25
  L1/L1WrappedStakedTONProxy.sol	5
  L1/L1WrappedStakedTONStorage.sol	28
  L2/GemFactory.sol	604
  L2/GemFactoryProxy.sol	5
  L2/GemFactoryStorage.sol	113
  L2/L2StandardERC20.sol	38
  L2/MarketPlace.sol	116
  L2/MarketPlaceStorage.sol	24
  L2/MarketPlaceProxy.sol	5
  L2/RandomPack.sol	83
  L2/RandomPackStorage.sol	24
  L2/RandomPackProxy.sol	5
  L2/Treasury.sol	170
  L2/WstonSwapPool.sol	116
  L2/WstonSwapPoolStorage.sol	20
  L2/WstonSwapPoolProxy.sol	5
  L2/Randomness/DRBConsumerBase.sol	30
  library/ForgeLibrary.sol	193
  library/GemLibrary.sol	35
  library/MiningLibrary.sol	15
  library/TransferLibrary.sol	19
  proxy/ProxyGemFactory.sol	97
  proxy/ProxyL1WrappedStakedTON.sol	97
  proxy/ProxyMarketPlace.sol	97
  proxy/ProxyRandomPack.sol	97
  proxy/ProxyStorage.sol	7
  proxy/ProxyWstonSwapPool.sol	97
  Total	2379

Requirement checklists

Readme.md

• [x] Does your repository have readme.md ?

see README.md

• Contract information

  • [x] Overview: What is the contract about? (share any relevant links)

  https://www.notion.so/tokamak/Project-Opal-Economical-System-6c8847ea71234931be1f144aefca6cd4

  • [x] List of requirements: what are requirements for the contract? (share any relevant links)

  see README.md

  • [x] Environment setting example

  see README.md

  • [x] Test example

  see README.md

General

• [x] Does your code contain sufficient commenting?
• [x] Does your code contain sufficient test scripts?

Agreement

• [x] I understand that it is my responsibility as a review requester to either make a new commit based on the review or explain the issue with the review (ex: duplicated issue, not an issue, etc)